Add parseRepeated function #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news about this PR ? Have the same issue with npm cookie |
|
Maybe this code duplication prevents this being merged. What about leverage existing "options" object adding a new key to configure desired behaviour? For instance it the name of this option could be "parseToArray" with default false ... |
Contributor
|
Yes, @jacklrs that makes the most sense -- add an option to the existing |
Contributor
|
Actually, looks like this was implemented in #108 , so I'm going to close this in favor of that PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for this #60
It basically uses the same code than parse but instead of assign in once, it concatenates it to an array.
E.g.
I tried to follow the current code style, used the same tests and benchmarks but I'm sure there's place for improvements.
@dougwilson